Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update transform learning to use class in NeutralNet.__init__ #425

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@thomasjpfan
Copy link
Member

commented Jan 20, 2019

Updates tutorial to use a class in NeutralNet.__init__.

thomasjpfan added some commits Jan 20, 2019

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2019

Could you quickly explain why you made that change?

@thomasjpfan

This comment has been minimized.

Copy link
Member Author

commented Jan 20, 2019

Previously, the module was created first and passed to NeuralNet. This PR pushes the use of the stateless class to creating the NeuralNet object.

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2019

Okay, so this is to encourage more "skorchy" usage. From my perspective, this is good to go, @ottonemo what do you think?

@ottonemo

This comment has been minimized.

Copy link
Collaborator

commented Jan 21, 2019

LGTM

@ottonemo ottonemo merged commit a9f1140 into skorch-dev:master Jan 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.