Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] ENH Uses checkpoint internally #463

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@thomasjpfan
Copy link
Member

commented Apr 27, 2019

Resolves #459

This PR updates TrainEndCheckpoint to use class composition (instead of inheritance) when using Checkpoint methods.

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator

commented May 1, 2019

Nice solution. Could you add a short entry to the CHANGES.md?

@BenjaminBossan BenjaminBossan added the bug label May 1, 2019

@thomasjpfan

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Added to CHANGES.md

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

Thanks, good work.

@BenjaminBossan BenjaminBossan merged commit 17256a1 into skorch-dev:master May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.