Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations for 0.6.0 release #476

Merged
merged 9 commits into from May 21, 2019

Conversation

Projects
None yet
2 participants
@BenjaminBossan
Copy link
Collaborator

commented May 17, 2019

Remove deprecations that had a sufficiently long deprecation period.

BenjaminBossan added some commits May 17, 2019

BenjaminBossan
Remove deprecated save_history and load_history
Now use save_params with f_history keyword.
BenjaminBossan
Remove deprecated filter_requires_grad and filtered_optimizers
Now use skorch.callbacks.Freezer if you want to freeze parameters.
BenjaminBossan
Remove deprecated "wrong" slice of history
It used to be possible to do history[j, 'batches', somekey] but that
was inconsistent and should really be history[j, 'batches', :,
somekey] because the 2nd to last key relates to the batch indices, not
the batch keys. This inconsistent behavior is no longer supported.
BenjaminBossan
Remove support for unpickling old skorch nets
With PyTorch 1.1.0, we can no longer unpickle old models that have an
optimizer (i.e. basically all models). Therefore, we may as well drop
the support for unpickling old files now, when moving to PyTorch
1.1.0.
BenjaminBossan
Remove deprecated device argument from Dataset
This argument didn't do anything. Now passing it raises an error.
BenjaminBossan
@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented May 17, 2019

Addresses #467

BenjaminBossan
Bump up PyTorch version to 1.1.0 in travis.yml
We need it for the CyclicLR implemenation in PyTorch.
@thomasjpfan
Copy link
Member

left a comment

LGTM

@BenjaminBossan BenjaminBossan merged commit 4d68086 into master May 21, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.