Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be backward compatible with torch 1.0 #483

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@ottonemo
Copy link
Collaborator

commented Jun 11, 2019

When using the newest skorch version with torch 1.0.0 the following exception is thrown:

  File "/projects/Code/models.py", line 8, in <module>
    from skorch.callbacks import BatchScoring
  File "/projects/Code/skorch/skorch/__init__.py", line 7, in <module>
    from .net import NeuralNet
  File "/projects/Code/skorch/skorch/net.py", line 14, in <module>
    from skorch.callbacks import EpochTimer
  File "/projects/Code/skorch/skorch/callbacks/__init__.py", line 14, in <module>
    from .lr_scheduler import *
  File "/projects/Code/skorch/skorch/callbacks/lr_scheduler.py", line 16, in <module>
    from torch.optim.lr_scheduler import CyclicLR as TorchCyclicLR
ImportError: cannot import name 'CyclicLR'

Since 1.1.0 is not that old we should probably support 1.0.x for some time.

Be backward compatible with torch 1.0
Since 1.1.0 is not that old we should probably support
1.0.x for some time.
@thomasjpfan
Copy link
Member

left a comment

Makes sense.

@BenjaminBossan BenjaminBossan merged commit 51000d1 into master Jun 11, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.