Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MNIST torchvision example #490

Merged
merged 4 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@ottonemo
Copy link
Collaborator

commented Jun 25, 2019

Utilizes and tests skorch.helper.SliceDataset to do grid search and
plotting of examples.

Add MNIST torchvision example
Utilizes and tests `skorch.helper.SliceDataset` to do grid search and
plotting of examples.
@review-notebook-app

This comment has been minimized.

Copy link

commented Jun 25, 2019

Check out this pull request on ReviewNB: https://app.reviewnb.com/skorch-dev/skorch/pull/490

You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB.

@ottonemo ottonemo marked this pull request as ready for review Jun 25, 2019

@ottonemo ottonemo requested a review from BenjaminBossan Jun 25, 2019

@ottonemo

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

@thomasjpfan @BenjaminBossan revised, please review again.

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

LGTM

@thomasjpfan

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

There is a new skorch/tests/net_cuda.pkl file in this PR.

@ottonemo

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 2, 2019

@thomasjpfan I reset net_cuda.pkl to master, however we should probably update the pickle whenever there is a change (to keep the CI tests that depend on this pickle up-to-date). It's just not in the scope of this PR.

Please review again.

@ottonemo

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 9, 2019

@thomasjpfan is this good to go?

@thomasjpfan
Copy link
Member

left a comment

LGTM

@thomasjpfan thomasjpfan merged commit 1ed77b1 into master Jul 9, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.