Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment.yml #508

Merged
merged 6 commits into from Aug 12, 2019

Conversation

@BenjaminBossan
Copy link
Collaborator

commented Aug 8, 2019

For some reason, the old one didn't work for me anymore. I got the following errors:

$ conda --version
conda 4.7.10
$ conda env create
ResolvePackageNotFound: 
  - setuptools==27.2.0=py36_0
  - xz==5.2.2=1
  - zlib==1.2.8=3
  - readline==6.2=2
  - sqlite==3.13.0=0
  - openssl==1.0.2l=0
  - tqdm=4.14.0
  - tk==8.5.18=0
  - python==3.6.2=0

Could someone please confirm this?

If this is true, I wonder why this happens. Shouldn't conda allow reproducible builds? Were all those packages removed?

Update environment.yml
The old one didn't work for me anymore.

@BenjaminBossan BenjaminBossan requested review from thomasjpfan and ottonemo Aug 8, 2019

@BenjaminBossan BenjaminBossan self-assigned this Aug 8, 2019

@thomasjpfan

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Yea conda removed some packages from their default/free channel, if we want to have access to the old packages we need to run:

conda config --set restore_free_channel true
@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

Well in that case we should probably update the environment.yml. I removed the third part of the package versions (foo==bar==BAZ) because I found that this prevents builds from being reproducible. I'm not sure if they are needed.

Can you verify that the updated environment.yml works?

@thomasjpfan

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

On OSX, I get this:

Collecting package metadata (repodata.json): done
Solving environment: failed

ResolvePackageNotFound: 
  - libgcc-ng=9.1.0
  - libstdcxx-ng=9.1.0
  - libgfortran-ng=7.3.0

Removing them worked.

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 10, 2019

On OSX, I get this:

Do you mean with the new or the old environment.yml?

@thomasjpfan

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

New one in this PR

BenjaminBossan added some commits Aug 10, 2019

Remove wrong xfail marker
The test no longer fails, though it's not clear when it stopped
failing.
Make repr unit tests pass with pytorch >= 1.2
Tests still work with lower versions.
@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 10, 2019

I updated the env by removing the offending lines. I also ticked up the default Python version to 3.7.

Additionally, I changed the unit tests to be compatible with the latest pytorch release (1.2).

For travis, use Python=3.7.3
Python 3.7.4 seems to have a problem with pip install numpy.
@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 11, 2019

I had to change the Python 3.7 version to 3.7.3 from 3.7.4 (default) because numpy couldn't be installed otherwise. Locally, I could replicate this by just creating an env with Python 3.7.4 and calling pip install numpy. Different recent numpy versions all had the same effect. Oddly, I couldn't find a solution for this, even though this should affect many people.

@thomasjpfan
Copy link
Member

left a comment

The environment.yml works for me now.

With the adjustments for PyTorch 1.2, lets update the PYTORCH_VERSION in travis as well?

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 11, 2019

With the adjustments for PyTorch 1.2, lets update the PYTORCH_VERSION in travis as well?

I would prefer to separate this and then immediately make new release.

@BenjaminBossan BenjaminBossan marked this pull request as ready for review Aug 11, 2019

@BenjaminBossan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2019

@ottonemo What's your take?

@ottonemo

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

LGTM. I'm for merging this right now and making a separate PR for PyTorch 1.2 related changes and doing a release after that.

@ottonemo ottonemo merged commit 158bd3d into master Aug 12, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.