Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presence validations for unique identifiers reported from shops #51

Closed
wants to merge 4 commits into from

Conversation

alistat
Copy link
Contributor

@alistat alistat commented Dec 27, 2018

Analytics Tracking Script will:

  1. Make sure that the payload given to addOrder or addItem commands is a valid JSON before reporting them
  2. Make sure addOrder has been supplied with a non-empty order_id field before reporting it
  3. Make sure addItem has been supplied with non-empty order_id and product_id fields before reporting it
  4. Log appropriate validation errors to console whenever the above constraints are not met

Also, Analytics Tracking Script will:

  • Accept (unstringified) Object as payload. JSON.stringify(...) is not needed anymore.

Documentation Update: skroutz/developer.skroutz.gr/pull/93

@alistat
Copy link
Contributor Author

alistat commented Jan 4, 2019

Closes in favor of #52

@alistat alistat closed this Jan 4, 2019
@kosdiamantis kosdiamantis deleted the command_validation_minimal branch January 11, 2019 10:52
harrisred added a commit to skroutz/skroutz-analytics-woocommerce that referenced this pull request Nov 21, 2019
Since skroutz/analytics.js#51 Analytics
accepts (unstringified) Object as payload
harrisred added a commit to skroutz/skroutz-analytics-woocommerce that referenced this pull request Nov 21, 2019
Since skroutz/analytics.js#51 Analytics
accepts (unstringified) Object as payload
harrisred added a commit to skroutz/skroutz-analytics-woocommerce that referenced this pull request Nov 21, 2019
Since skroutz/analytics.js#51 Analytics
accepts (unstringified) Object as payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant