Allow duplicate column names in Joiner #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-Maladiere
approved these changes
Jul 25, 2024
Member
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Very nice follow-up, LGTM
TheooJ
approved these changes
Jul 25, 2024
Contributor
TheooJ
left a comment
TheooJ
left a comment
There was a problem hiding this comment.
Thanks, just some nitpicks
Do we want an entry in the docstrings Attributes section for all_outputs_ ?
Co-authored-by: Théo Jolivet <57430673+TheooJ@users.noreply.github.com>
Contributor
|
Thanks @jeromedockes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random (but consistent across calls to transform) strings are inserted in duplicate names to avoid errors.
This is to be consistent with the AggJoiner and AggTarget