Skip to content

Fonts in inline report#1038

Merged
GaelVaroquaux merged 9 commits into
skrub-data:mainfrom
jeromedockes:fonts-in-inline-report
Aug 5, 2024
Merged

Fonts in inline report#1038
GaelVaroquaux merged 9 commits into
skrub-data:mainfrom
jeromedockes:fonts-in-inline-report

Conversation

@jeromedockes
Copy link
Copy Markdown
Member

@jeromedockes jeromedockes commented Aug 5, 2024

partly addresses #1037

  • don't set the font when the report is inserted in another page
  • reduce monspaced text size
  • reduce banner font size

can be discussed in another pr:

  • scale report according to parent element's font size
  • reduce the font size further

@jeromedockes
Copy link
Copy Markdown
Member Author

jeromedockes commented Aug 5, 2024

here is a screenshot in vscode

screenshot_2024-08-05T20:23:52+02:00

Copy link
Copy Markdown
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already a great improvement.

I was about to merge, but maybe a changelog entry? I suspect that this is a change that people want to know about

@jeromedockes
Copy link
Copy Markdown
Member Author

thanks! I added the changelog entry

@jeromedockes
Copy link
Copy Markdown
Member Author

now in vscode and the sphinx documentation the reports use the same font at the same size as the rest of the page.

in a jupyter notebook, by default in most browsers the text will be 15px and the report will be 16px.

if a user changes the default font size in their browser settings (eg to accomodate their eyesight), the difference will be bigger because the report will scale accordingly and the notebook text won't and will stay fixed at 15px. But I would argue the correct behavior is the report's in this case

@GaelVaroquaux
Copy link
Copy Markdown
Member

This is a net improvement. Merging. Thanks!!

@GaelVaroquaux GaelVaroquaux merged commit a97e1a4 into skrub-data:main Aug 5, 2024
jeromedockes added a commit to jeromedockes/skrub that referenced this pull request Sep 25, 2024
* don't specify font in inline reports

* smaller font in pre, code

* smaller font for banner

* [doc build]

* smaller text boxes

* [doc build]

* smaller title

* [doc build]

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants