Easier copying of TableReport table cells#1048
Merged
Vincent-Maladiere merged 18 commits intoskrub-data:mainfrom Sep 4, 2024
Merged
Easier copying of TableReport table cells#1048Vincent-Maladiere merged 18 commits intoskrub-data:mainfrom
Vincent-Maladiere merged 18 commits intoskrub-data:mainfrom
Conversation
Member
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Hello Jérome, unfortunately, I still can't copy-past with a single click on Chrome and Chrome + Arc. I need to double-click to copy. I will try on Firefox.
Member
|
Yes, so it works fine on Firefox but not on Chrome. |
Member
Author
|
cool thanks for checking! |
Member
Author
|
I can't reproduce the issue on Chrome on Linux |
Member
|
Ok, so unless there is an easy fix, I guess we can skip this feature for Chrome on MacOS for now? |
Member
Author
|
I'm guessing that's a significant proportion of users so I'd like to investigate a bit more (also I need to check the failing test) |
21 tasks
jeromedockes
changed the title
Member
Author
|
ok @Vincent-Maladiere this one is ready now |
Vincent-Maladiere
approved these changes
Sep 4, 2024
Member
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
It works fine on Chrome for MacOS!
jeromedockes
added a commit
to jeromedockes/skrub
that referenced
this pull request
Sep 25, 2024
* highlight selected cell with border instead of color * copy cell repr value on copy event * only override copy event if selection is empty * changelog * add test * [doc build] * update changelog * [doc build] * _ * [doc build] * _ * _ * [doc build] * tab to selected cell * _ * [doc build] * _ * [doc build]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small adjustments after euroscipy discussions
Will add a few more soon