Skip to content

Conversation

@jeromedockes
Copy link
Member

No description provided.

@GaelVaroquaux
Copy link
Member

Can you please do a trivial change (eg add an empty line) to the getting started example, so that our CI renders it, and we can check how the table report looks like via the rendered docs?

Thanks!

@jeromedockes
Copy link
Member Author

jeromedockes commented Sep 5, 2024 via email

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Sep 5, 2024 via email

@jeromedockes
Copy link
Member Author

jeromedockes commented Sep 5, 2024 via email

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Sep 5, 2024 via email

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful, LGTM!

Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

This looks good to merge to me

@GaelVaroquaux
Copy link
Member

Two approvals, merging

@GaelVaroquaux GaelVaroquaux merged commit 142cd54 into skrub-data:main Sep 5, 2024
@jeromedockes jeromedockes deleted the add-summary-stats-panel branch September 5, 2024 20:05
jeromedockes added a commit to jeromedockes/skrub that referenced this pull request Sep 25, 2024
* add tab panel with summary stats table

* [doc build]

* _

* update tests

* tooltips

* changelog

* [doc build]

* allow filtering stats tab columns

* [doc build]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants