-
Notifications
You must be signed in to change notification settings - Fork 182
Add summary stats panel in report #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summary stats panel in report #1056
Conversation
|
Can you please do a trivial change (eg add an empty line) to the getting started example, so that our CI renders it, and we can check how the table report looks like via the rendered docs? Thanks! |
|
Can you please do a trivial change (eg add an empty line) to the getting started example, so that our CI renders it, and we can check how the table report looks like via the rendered docs?
Thanks!
yep, I did it on the previous one but forgot to redo it after the last
change.
FYI git commit has the `--allow-empty` option in cases where you want to
push a commit to trigger the CI but don't have any change to make
|
|
FYI git commit has the `--allow-empty` option in cases where you want to push a commit to trigger the CI but don't have any change to make
Indeed. But I think our CI detects that the example has not been changed and does not run, to decrease computation costs.
|
|
Indeed. But I think our CI detects that the example has not been changed and does not run, to decrease computation costs.
ah yes that's a good point, [ci-build] runs all the examples
|
|
ah yes that's a good point, [ci-build] runs all the examples
But only once. And what we would like is that this specific example is rerun for each push, to facilitate looking at the TableReport.
|
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful, LGTM!
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
This looks good to merge to me
|
Two approvals, merging |
* add tab panel with summary stats table * [doc build] * _ * update tests * tooltips * changelog * [doc build] * allow filtering stats tab columns * [doc build]
No description provided.