Skip to content

Conversation

@jeromedockes
Copy link
Member

@jeromedockes jeromedockes commented Sep 10, 2024

it is now possible to sort the table in the "stats" tab panel eg from columns with fewest null values to most null values

WIP:

  • add tests
  • improve a bit the look & position of the buttons

@Vincent-Maladiere
Copy link
Member

Nice addition, is it possible to remove the shadow around the buttons?

@jeromedockes
Copy link
Member Author

@Vincent-Maladiere I removed the shadows and also changed the icons for something more explicit. it should be ok now

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vincent-Maladiere Vincent-Maladiere merged commit a043903 into skrub-data:main Sep 16, 2024
jeromedockes added a commit to jeromedockes/skrub that referenced this pull request Sep 25, 2024
* add sorting of the summary statistics table

* _

* buttons display

* _

* _

* _

* _

* changelog + formatting

* remove shadow below buttons

* add tests

* better icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants