fix error when report input contains lists #1066#1087
Merged
jeromedockes merged 2 commits intoskrub-data:mainfrom Sep 25, 2024
Merged
fix error when report input contains lists #1066#1087jeromedockes merged 2 commits intoskrub-data:mainfrom
jeromedockes merged 2 commits intoskrub-data:mainfrom
Conversation
Member
|
Are these errors new since last release, or were they already there in last release? If they were already there, a changelog entry would be nice |
GaelVaroquaux
approved these changes
Sep 25, 2024
Member
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
There was a problem hiding this comment.
LGTM, ideally with the changelog entry
Member
Author
|
you're right it needs a changelog entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1066