Skip to content

Adds column name in html table vectorizer#1093

Merged
jeromedockes merged 8 commits into
skrub-data:mainfrom
Shree7676:htmlTableVectorizer
Sep 27, 2024
Merged

Adds column name in html table vectorizer#1093
jeromedockes merged 8 commits into
skrub-data:mainfrom
Shree7676:htmlTableVectorizer

Conversation

@Shree7676

Copy link
Copy Markdown
Contributor

#948
cc @jeromedockes
@ PyData Paris Sprint

@Shree7676

Copy link
Copy Markdown
Contributor Author

to fix the codecov/patch
should I just update the test case name as test_sk_visual_block_

Comment thread skrub/tests/test_table_vectorizer.py Outdated
Comment thread skrub/tests/test_table_vectorizer.py
Shree7676 and others added 3 commits September 27, 2024 14:17

@jeromedockes jeromedockes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @Shree7676 !!

@jeromedockes jeromedockes merged commit 4983834 into skrub-data:main Sep 27, 2024
@Shree7676 Shree7676 deleted the htmlTableVectorizer branch October 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants