Skip to content

Conversation

@jeromedockes
Copy link
Member

also the tables are compressed a bit more

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Vincent-Maladiere
Copy link
Member

Here's how it looks on VSCode!

Screenshot 2024-10-02 at 10 09 18

@jeromedockes jeromedockes marked this pull request as ready for review October 2, 2024 08:35
@jeromedockes
Copy link
Member Author

Here's how it looks on VSCode!

cool thanks a lot for checking!

@jeromedockes
Copy link
Member Author

thanks for the review @Vincent-Maladiere , merging

@jeromedockes jeromedockes merged commit 11b8bdc into skrub-data:main Oct 2, 2024
@jeromedockes jeromedockes deleted the TR-inherit-font-size branch October 2, 2024 08:47
@GaelVaroquaux
Copy link
Member

Great!! This is a big deal

I think that this warrants a small line in the changelog, as it impacts users (positively)

@jeromedockes
Copy link
Member Author

jeromedockes commented Oct 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants