-
Notifications
You must be signed in to change notification settings - Fork 203
base sizes in report on font size of parent element #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeromedockes
merged 9 commits into
skrub-data:main
from
jeromedockes:TR-inherit-font-size
Oct 2, 2024
Merged
base sizes in report on font size of parent element #1098
jeromedockes
merged 9 commits into
skrub-data:main
from
jeromedockes:TR-inherit-font-size
Oct 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-Maladiere
approved these changes
Oct 1, 2024
Member
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Member
Member
Author
cool thanks a lot for checking! |
Member
Author
|
thanks for the review @Vincent-Maladiere , merging |
Member
|
Great!! This is a big deal I think that this warrants a small line in the changelog, as it impacts users (positively) |
Member
Author
|
I think that this warrants a small line in the changelog, as it impacts users (positively)
Oops I forgot the changelog I'll do it in another one
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

also the tables are compressed a bit more