make sample table sequentially focusable when no cell is active#1101
Merged
GaelVaroquaux merged 4 commits intoskrub-data:mainfrom Oct 7, 2024
Merged
make sample table sequentially focusable when no cell is active#1101GaelVaroquaux merged 4 commits intoskrub-data:mainfrom
GaelVaroquaux merged 4 commits intoskrub-data:mainfrom
Conversation
glemaitre
approved these changes
Oct 7, 2024
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
Nice. If you can only solve the merge conflict.
Member
|
I fixed the merge conflict. Launching auto-merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently before clicking on any of the cells it is not possible to bring focus to the sample table with the keyboard. this PR makes the table sequentially focusable (with Tab); when it receives focus it activates the first cell