add column_associations public function#1109
Merged
jeromedockes merged 7 commits intoskrub-data:mainfrom Oct 22, 2024
Merged
Conversation
Vincent-Maladiere
approved these changes
Oct 21, 2024
Member
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Very nice! Should we append this function to the "Generating an HTML report" API reference section?
By the way, should we have an entry of the TableReport in the user guide of the documentation? This is such a major feature, we could talk about it a little. WDYT?
Member
Author
yes! I keep forgetting to do that ...
I think that's a good idea, we could mention the report and the functions to patch the dataframes display. after all we do have a full section of the user guide just for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
column_associations(the function that computes the pairwise cramer v stats shown in the tablereport) as a function accessible in the public api