Faster svg viewbox computation in tablereport#1138
Merged
jeromedockes merged 3 commits intoskrub-data:mainfrom Nov 15, 2024
Merged
Faster svg viewbox computation in tablereport#1138jeromedockes merged 3 commits intoskrub-data:mainfrom
jeromedockes merged 3 commits intoskrub-data:mainfrom
Conversation
GaelVaroquaux
approved these changes
Nov 14, 2024
Member
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
There was a problem hiding this comment.
LGTM, but I think that it would be useful to add a short changelog entry: it's user-visible enough
Member
Author
|
thanks @GaelVaroquaux . the computation of bounding boxes in the browser has not been released yet so I did not create a changelog entry but I added this pr's number to the entry about improving the svg text |
Member
Author
|
I marked it as draft because @Vincent-Maladiere agreed to check it works in a different environment so we should wait for that info before merging |
Vincent-Maladiere
approved these changes
Nov 15, 2024
Member
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
LGTM after testing on my machine
Member
Author
|
thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the computation of the correct viewbox for the plots is done currently is slow when there are many columns.
This makes all the bounding box computation in one go with no changes to the document in between to avoid unnecessary recomputations of the styles and layout
also as it adds a few functions to the report code, now is a good time to put it in a module to avoid polluting the global namespace so this PR adds that too