Skip to content

fix histogram plot failure on float('inf')#1151

Merged
Vincent-Maladiere merged 4 commits intoskrub-data:mainfrom
jeromedockes:fix-1134
Nov 22, 2024
Merged

fix histogram plot failure on float('inf')#1151
Vincent-Maladiere merged 4 commits intoskrub-data:mainfrom
jeromedockes:fix-1134

Conversation

@jeromedockes
Copy link
Copy Markdown
Member

fixes #1134

this is a quick fix for #1134

later we can improve handling of infinite or very large values by

  • excluding them from the computation of summary statistics (?)
  • excluding them while setting the bounds of the shown histograms to avoid unhelpful histograms with only one bar

however this requires taking care to make sure that the user realizes those outliers have been discarded so may take a bit more discussion. So I suggest we avoid crashing for now so that the release 0.3.2 does not depend on solving these more subtle choices

@jeromedockes jeromedockes added this to the 0.3.2 milestone Nov 21, 2024
Copy link
Copy Markdown
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vincent-Maladiere Vincent-Maladiere merged commit 0f73984 into skrub-data:main Nov 22, 2024
@jeromedockes jeromedockes deleted the fix-1134 branch November 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableReport fails with np.inf

2 participants