ENH adding alias "regression" and "classification" #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Dec 6, 2024
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
I think that we should add an entry in the CHANGES.rst to acknowledge the new options.
| We can easily get a default pipeline for regression or classification: | ||
| >>> tabular_learner('regressor') # doctest: +SKIP | ||
| >>> tabular_learner('regression') # doctest: +SKIP |
Member
There was a problem hiding this comment.
For the later changes here and under, I don't think that we need to change the documentation.
glemaitre
reviewed
Dec 6, 2024
| ``tabular_learner`` is a recent addition and the heuristics used | ||
| to define an appropriate preprocessing based on the ``estimator`` may change | ||
| in future releases. | ||
Member
There was a problem hiding this comment.
I think that we need to amend as well the documentation in the long summary just above where we already mentioned "regressor" and "classifier".
glemaitre
reviewed
Dec 6, 2024
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
glemaitre
approved these changes
Dec 8, 2024
Vincent-Maladiere
approved these changes
Dec 9, 2024
Member
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
LGTM, thanks @mrastgoo :)
Member
|
awesome!! thanks a lot @mrastgoo :) |
jeromedockes
pushed a commit
to jeromedockes/skrub
that referenced
this pull request
Dec 11, 2024
TheooJ
pushed a commit
that referenced
this pull request
Dec 11, 2024
* bump version after 0.4.0 (#1162) * DOC Correct typo in TableReport docstring (#1168) * Add codespell support (#1126) * add python 3.13 (#1170) * add sections for the next release's changelogs (#1183) * Add a verbosity parameter to TableReport to control the printing of messages in stdout when opening summary report (#1182) * add verbose parameter to print_display to toggle on or off printing of progress messages when generating table report (#1188) * DOC add example for Cramer V for column_associations (#1186) * ENH adding alias "regression" and "classification" (#1180) * Bump codecov/codecov-action from 5.0.7 to 5.1.1 in the actions group (#1191) * remove use of matplotlib.rc_context (#1172) * MAINT adapt for scikit-learn 1.6 (#1135) * Revert "MAINT adapt for scikit-learn 1.6 (#1135)" (#1194) This reverts commit 18af508. * MAINT compatibility sklearn 1.6.0 (#1169) * MAINT fix nightly builds (#1193) * Updating contributing doc to add more detail on how to start (#1185) * FIX better display of object columns with multi-line repr in tablereport (#1196) * update changelog --------- Co-authored-by: Matt J. <matthieu.jouis@gmail.com> Co-authored-by: Yaroslav Halchenko <debian@onerussian.com> Co-authored-by: priscilla baah <66260270+priscilla-b@users.noreply.github.com> Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com> Co-authored-by: mrastgoo <mojdeh.rastgoo@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai> Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
TheooJ
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1177
Adding "regression" as an alias to "regressor" and "classification" to "classifier"