Add a verbosity parameter to TableReport to control the printing of messages in stdout when opening summary report#1182
Conversation
jeromedockes
left a comment
jeromedockes
left a comment
There was a problem hiding this comment.
Thank you very much @priscilla-b ! I took the liberty to push a small change to align the identation of the paragraph for the 'verbose' parameter in the docstring (the tools that check and generate html from the docstrings are quite picky about whitespace 😅 ) and the tests are passing now, which is great!
|
The last thing we need to take care of will be to edit the changelog, so that when we release the next version of skrub users can easily find out about this nice addition! could you add an entry to this part of the changelog, you can see the formatting in other entries below in the same file. in particular it needs to contain a sentence like to link the changelog entry to the PR and your GitHub account |
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
jeromedockes
left a comment
jeromedockes
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot @priscilla-b !! I will merge it once the CI finishes running. as a follow up we could also expose that option in the patch_display function (which is used in the upcoming course I mentioned yesterday)?
|
all green, merging! 🎉 thanks @priscilla-b :) |
Sure, going to look into this @jeromedockes |
|
great, thanks! I'm on the discord even when I'm not in the skrub room so don't hesitate to ping me there if you have any questions |
…essages in stdout when opening summary report (skrub-data#1182)
* bump version after 0.4.0 (#1162) * DOC Correct typo in TableReport docstring (#1168) * Add codespell support (#1126) * add python 3.13 (#1170) * add sections for the next release's changelogs (#1183) * Add a verbosity parameter to TableReport to control the printing of messages in stdout when opening summary report (#1182) * add verbose parameter to print_display to toggle on or off printing of progress messages when generating table report (#1188) * DOC add example for Cramer V for column_associations (#1186) * ENH adding alias "regression" and "classification" (#1180) * Bump codecov/codecov-action from 5.0.7 to 5.1.1 in the actions group (#1191) * remove use of matplotlib.rc_context (#1172) * MAINT adapt for scikit-learn 1.6 (#1135) * Revert "MAINT adapt for scikit-learn 1.6 (#1135)" (#1194) This reverts commit 18af508. * MAINT compatibility sklearn 1.6.0 (#1169) * MAINT fix nightly builds (#1193) * Updating contributing doc to add more detail on how to start (#1185) * FIX better display of object columns with multi-line repr in tablereport (#1196) * update changelog --------- Co-authored-by: Matt J. <matthieu.jouis@gmail.com> Co-authored-by: Yaroslav Halchenko <debian@onerussian.com> Co-authored-by: priscilla baah <66260270+priscilla-b@users.noreply.github.com> Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com> Co-authored-by: mrastgoo <mojdeh.rastgoo@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai> Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
…essages in stdout when opening summary report (#1182)
2 participants
Towards #1175