Skip to content

FIX better display of object columns with multi-line repr in tablereport#1196

Merged
TheooJ merged 4 commits intoskrub-data:mainfrom
jeromedockes:fix-1195
Dec 11, 2024
Merged

FIX better display of object columns with multi-line repr in tablereport#1196
TheooJ merged 4 commits intoskrub-data:mainfrom
jeromedockes:fix-1195

Conversation

@jeromedockes
Copy link
Copy Markdown
Member

@jeromedockes jeromedockes commented Dec 11, 2024

fixes #1195

@jeromedockes
Copy link
Copy Markdown
Member Author

using the example from the issue, on main branch:

screenshot_2024-12-11T18:10:50+01:00

with the proposed changes:

screenshot_2024-12-11T18:10:16+01:00

Copy link
Copy Markdown
Contributor

@TheooJ TheooJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@TheooJ TheooJ merged commit e24e907 into skrub-data:main Dec 11, 2024
@jeromedockes jeromedockes deleted the fix-1195 branch December 11, 2024 17:44
jeromedockes added a commit to jeromedockes/skrub that referenced this pull request Dec 11, 2024
TheooJ pushed a commit that referenced this pull request Dec 11, 2024
* bump version after 0.4.0 (#1162)

* DOC Correct typo in TableReport docstring (#1168)

* Add codespell support (#1126)

* add python 3.13 (#1170)

* add sections for the next release's changelogs (#1183)

* Add a verbosity parameter to TableReport to control the printing of messages in stdout when opening summary report (#1182)

* add verbose parameter to print_display to  toggle on or off printing of progress messages when generating table report (#1188)

* DOC add example for Cramer V for column_associations (#1186)

* ENH adding alias "regression" and "classification" (#1180)

* Bump codecov/codecov-action from 5.0.7 to 5.1.1 in the actions group (#1191)

* remove use of matplotlib.rc_context (#1172)

* MAINT adapt for scikit-learn 1.6 (#1135)

* Revert "MAINT adapt for scikit-learn 1.6 (#1135)" (#1194)

This reverts commit 18af508.

* MAINT compatibility sklearn 1.6.0 (#1169)

* MAINT fix nightly builds (#1193)

* Updating contributing doc to add more detail on how to start  (#1185)

* FIX better display of object columns with multi-line repr in tablereport (#1196)

* update changelog

---------

Co-authored-by: Matt J. <matthieu.jouis@gmail.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: priscilla baah <66260270+priscilla-b@users.noreply.github.com>
Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com>
Co-authored-by: mrastgoo <mojdeh.rastgoo@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableReport doesn't like python objects like nested sklearn estimators

2 participants