Changing the name of SimpleCleaner to Cleaner#1275
Merged
rcap107 merged 5 commits intoskrub-data:mainfrom Apr 3, 2025
Merged
Conversation
rcap107
added a commit
to rcap107/skrub
that referenced
this pull request
Apr 3, 2025
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
rcap107
added a commit
to rcap107/skrub
that referenced
this pull request
Apr 3, 2025
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
rcap107
added a commit
that referenced
this pull request
Apr 3, 2025
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring first, now I need to add the deprecation warning and add back SimpleCleaner as a subclass of Cleaner