Skip to content

Adding datetime_format parameter to TableVectorizer and Cleaner for handling custom formats - #1358

Merged
jeromedockes merged 3 commits into
skrub-data:mainfrom
rcap107:add-datetime-format
May 5, 2025
Merged

Adding datetime_format parameter to TableVectorizer and Cleaner for handling custom formats#1358
jeromedockes merged 3 commits into
skrub-data:mainfrom
rcap107:add-datetime-format

Conversation

@rcap107

@rcap107 rcap107 commented Apr 30, 2025

Copy link
Copy Markdown
Member

No description provided.

@rcap107
rcap107 marked this pull request as ready for review April 30, 2025 14:30

@jeromedockes jeromedockes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @rcap107 ! super useful when we have weirdly formatted datetimes (which is all the time :D )

@jeromedockes

Copy link
Copy Markdown
Member

if either @Vincent-Maladiere or @glemaitre could do a second review

@jeromedockes jeromedockes added this to the 0.6.0 milestone Apr 30, 2025
@jeromedockes
jeromedockes merged commit 5f7c13f into skrub-data:main May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants