Repository navigation
Coalesce optional dependencies into dev - #1404
Merged
GaelVaroquaux merged 9 commits intoMay 25, 2025
Merged
Conversation
Vincent-Maladiere
marked this pull request as ready for review
May 23, 2025 08:32
rcap107
reviewed
May 23, 2025
|
|
||
| [tool.pixi.feature.optional.dependencies] | ||
| pyarrow = "*" | ||
| pyarrow = "<20.0.0" |
Member
There was a problem hiding this comment.
why is there a limit on the pyarrow version?
Member
Author
There was a problem hiding this comment.
There is an issue with the last version of pyarrow regarding loading parquet having uint32 as index. This is a temporary fix for us, I hope this will be fixed in a later version on pyarrow side.
Member
Author
There was a problem hiding this comment.
I'll see if we can workaround it in skrub in the meantime in this PR
Member
Author
There was a problem hiding this comment.
Ok, I simply loaded and rewrote the failing parquet file using polars, and it fixed our pyarrow issue; no need to change pyarrow version indeed :)
rcap107
approved these changes
May 23, 2025
rcap107
left a comment
rcap107
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks a lot @Vincent-Maladiere
GaelVaroquaux
approved these changes
May 25, 2025
glemaitre
pushed a commit
to glemaitre/skrub
that referenced
this pull request
Jun 6, 2025
glemaitre
pushed a commit
to glemaitre/skrub
that referenced
this pull request
Jun 6, 2025
rcap107
pushed a commit
that referenced
this pull request
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1375
Let's wait for #1393 to be merged, as it changes the install and contributing sections.