Add stop-words to StringEncoder#1415
Merged
Vincent-Maladiere merged 6 commits intoJun 4, 2025
Merged
Conversation
ArturoAmorQ
reviewed
May 26, 2025
ArturoAmorQ
left a comment
ArturoAmorQ
left a comment
Contributor
There was a problem hiding this comment.
Not a maintainer here, but if I may have a comment, how about we also mention in the dosctring
If None, no stop words will be used.
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Member
Author
|
You're right! I scratched that part because I would have to mention the |
rcap107
reviewed
May 28, 2025
|
|
||
| Changes | ||
| ------- | ||
| - :class:`StringEncoder` now exposes the `stop_words` argument, which is passed to the |
Member
There was a problem hiding this comment.
I think the warning should remain at the top of the Changes section
rcap107
reviewed
May 28, 2025
rcap107
approved these changes
Jun 4, 2025
rcap107
left a comment
rcap107
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks @Vincent-Maladiere ! This should cover a lot of use cases.
Member
Author
|
Merging, as @GaelVaroquaux agreed to this PR during the skrub meeting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1402 and add a small footnote in the StringEncoder.