Add method that checks if a column is sorted - #1512
Merged
Merged
Conversation
DeaMariaLeon
marked this pull request as ready for review
July 11, 2025 10:26
Vincent-Maladiere
approved these changes
Jul 11, 2025
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
Member
There was a problem hiding this comment.
Hello @DeaMariaLeon, thank you for this PR! LGTM :)
Member
|
Could you add a small entry in the changelog (CHANGES.rst) before we merge? Thanks! |
Contributor
Author
|
Hello @Vincent-Maladiere I added the entry to the changelog 😇... and it's green. Thanks for the review. :) |
Member
|
Great! Let's wait for a second pair of eyes to review it before merging :) |
MarieSacksick
pushed a commit
to MarieSacksick/skrub
that referenced
this pull request
Jul 18, 2025
Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
MarieSacksick
pushed a commit
to MarieSacksick/skrub
that referenced
this pull request
Jul 18, 2025
Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #1398
skrub sprint at Probabl's 2025-07-09
Adds a column in Stats:
For
df = pl.DataFrame(dict(a=[1, 2, 1], b=['one', 'three', 'two'], c=[1, 2, 3]))I need to add tests.Edit: codecov seems fine. So waiting for feedback now.