Fix display of DataOp in google colab - #1590
Merged
GaelVaroquaux merged 5 commits intoSep 9, 2025
Merged
Conversation
jeromedockes
changed the title
rcap107
approved these changes
Sep 9, 2025
rcap107
left a comment
rcap107
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks a lot @jeromedockes
rcap107
pushed a commit
to rcap107/skrub
that referenced
this pull request
Sep 25, 2025
rcap107
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1589
Graphviz generates SVG
<a>elements to display tooltips, and does not set thetargetattribute. This results in an exception being raised by a script in google colab (I guess this is a security measure). A quick fix is to manually add the attribute in the SVG output.As a side note, as xlink:title is deprecated we could edit the SVG to rely on an
<title>element instead but probably not worth the effort.