store & report dataop evaluation timing - #1596
Conversation
+ small refactoring of eval function
8587684 to
2c833e4
Compare
2c833e4 to
d80a2ac
Compare
| {% if eval_duration is not none %} | ||
| <div> | ||
| <h3>Computation time</h3> | ||
| {{ "{:.2g}".format(eval_duration) }} s |
There was a problem hiding this comment.
I think minutes should also be added, I could imagine some nodes taking longer than 60 seconds to fit on larger data
There was a problem hiding this comment.
ok I improved a bit the formatting:
|
This looks really good, thanks a lot @jeromedockes Maybe this should also be added to the param searches? though in that case it would just be the sum of all runs. |
Maybe, yes. ATM we don't have those kind of detailed node-by-node reporting for the param searches, I guess what is interesting in param search is more aggregated information such as the mean fit time of the whole pipeline as shown in the in any case I would suggest exploring that in another issue; now at least the information is available in the node |
Yes better do that |
rcap107
left a comment
rcap107
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks a lot @jeromedockes
|
Can you add a mention of the evaluation time in the docstring for the We should have a proper section on the functions of the full report in the user guide as well (in a separate PR). |
2 participants
This adds to the dataop's report the time it took to evaluate each node
ATM it is shown here in the
full_report:zoom:
I also took the opportunity to do a bit of refactoring & slightly improving comments in the run() function in which the timing is added