FEA Adding FeatureAugmenter - #409
Merged
GaelVaroquaux merged 41 commits intoJan 17, 2023
Merged
Conversation
LilianBoulard
left a comment
LilianBoulard
left a comment
Member
There was a problem hiding this comment.
Just a few rewordings and typos
Member
Author
|
Thanks! Will make this ready for review in a few hours, just to check if everything works fine :) |
Co-authored-by: Lilian <lilian@boulard.fr>
Co-authored-by: Lilian <lilian@boulard.fr>
Co-authored-by: Lilian <lilian@boulard.fr>
jovan-stojanovic
marked this pull request as ready for review
November 16, 2022 10:36
LilianBoulard
approved these changes
Jan 4, 2023
Member
Author
|
When using the FeatureAugmenter, I found out that tuning the |
Member
|
When using the FeatureAugmenter, I found out that tuning the ngram_range and analyzer parameters of the fuzzy_join may be also useful sometimes. Do you think it's a good idea to introduce them in the class as parameters?
If you find them useful than yes, we should add them.
|
Member
|
I agree, moreover it's a common parameter in dirty_cat so users are probably already familiar with it |
Member
Author
|
Ok, thanks, I added it to the FA. |
GaelVaroquaux
approved these changes
Jan 17, 2023
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
Member
There was a problem hiding this comment.
LTGM. Great work. Thank you!!
Member
|
I merged. Congratulations! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the discussion in #403, here is a first version of the Feature Augmenter.
This is a transformer that will allow the users to pass a main table and some auxiliary tables to fuzzy join with.
(I need to add an example before making it ready for review)