Skip to content

Rename SuperVectorizer to TableVectorizer - #484

Merged
GaelVaroquaux merged 10 commits into
skrub-data:mainfrom
jovan-stojanovic:rename_super_vectorizer
Feb 1, 2023
Merged

Rename SuperVectorizer to TableVectorizer#484
GaelVaroquaux merged 10 commits into
skrub-data:mainfrom
jovan-stojanovic:rename_super_vectorizer

Conversation

@jovan-stojanovic

Copy link
Copy Markdown
Member

Fix #481

@GaelVaroquaux GaelVaroquaux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor suggestions (which I am going to commit right away), and this is mergeable.

Thanks a lot!!

Comment thread benchmarks/tablevectorizer_tuning.py Outdated
Comment thread benchmarks/tablevectorizer_tuning.py Outdated
Comment thread dirty_cat/tests/test_table_vectorizer.py Outdated
@GaelVaroquaux
GaelVaroquaux merged commit 56f708b into skrub-data:main Feb 1, 2023
@GaelVaroquaux

Copy link
Copy Markdown
Member

Merged!!

@jovan-stojanovic
jovan-stojanovic deleted the rename_super_vectorizer branch May 16, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename SuperVectorizer to TableVectorizer

2 participants