Add functions for exploring KEN embeddings - #539
Merged
Conversation
jovan-stojanovic
requested changes
Apr 11, 2023
jovan-stojanovic
left a comment
jovan-stojanovic
left a comment
Member
There was a problem hiding this comment.
Thanks! I added a few comments. In a second iteration, we can add also simple reproducible examples to illustrate how people can easily use these functions. Maybe we can also think of adding a separate section for Datasets on the website, as it is growing.
Member
Author
Absolutely, and I think it could be included in the scope of #546 :) |
jovan-stojanovic
approved these changes
Apr 14, 2023
jovan-stojanovic
left a comment
jovan-stojanovic
left a comment
Member
There was a problem hiding this comment.
One minor typo and LGTM!
Member
|
Will merge when all the tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #495