-
Notifications
You must be signed in to change notification settings - Fork 129
Add functions for exploring KEN embeddings #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a few comments. In a second iteration, we can add also simple reproducible examples to illustrate how people can easily use these functions. Maybe we can also think of adding a separate section for Datasets on the website, as it is growing.
Absolutely, and I think it could be included in the scope of #546 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor typo and LGTM!
Will merge when all the tests pass |
Fixes #495