Skip to content

Add functions for exploring KEN embeddings #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 14, 2023

Conversation

LilianBoulard
Copy link
Member

Fixes #495

@LilianBoulard LilianBoulard added the enhancement New feature or request label Apr 4, 2023
@LilianBoulard LilianBoulard added this to the 0.4.1 milestone Apr 4, 2023
@LilianBoulard LilianBoulard self-assigned this Apr 4, 2023
Copy link
Member

@jovan-stojanovic jovan-stojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few comments. In a second iteration, we can add also simple reproducible examples to illustrate how people can easily use these functions. Maybe we can also think of adding a separate section for Datasets on the website, as it is growing.

@LilianBoulard
Copy link
Member Author

In a second iteration, we can add also simple reproducible examples to illustrate how people can easily use these functions.

Absolutely, and I think it could be included in the scope of #546 :)

Copy link
Member

@jovan-stojanovic jovan-stojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo and LGTM!

@jovan-stojanovic
Copy link
Member

Will merge when all the tests pass

@jovan-stojanovic jovan-stojanovic merged commit 9c07412 into skrub-data:main Apr 14, 2023
@LilianBoulard LilianBoulard deleted the ken_types branch April 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help users find relevant ken types
2 participants