Merged
Conversation
Comment on lines
-125
to
-129
| # (we need to require the experimental feature for scikit-learn versions | ||
| # earlier than 1.0): | ||
| from sklearn.experimental import enable_hist_gradient_boosting | ||
|
|
||
| # We can now import the |HGBR| from ensemble |
Member
Author
|
Should be good to review, thanks! |
GaelVaroquaux
approved these changes
Jun 15, 2023
Member
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Nice!!!
It's so good to have all those cleanups. Thanks for going through the code and finding them.
LGTM
Member
|
LGTM. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the minimal versions of all dependencies and removes the requirement on
requests(we don't use directly).For numpy, scipy and pandas, versions date back to mid/late 2022, and scikit-learn 1.2.1 was released in January.