add get_feature_names_out to MinHashEncoder - #616
Merged
jovan-stojanovic merged 6 commits intoJun 26, 2023
Conversation
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
Member
There was a problem hiding this comment.
Hey @LeoGrin, thanks for the PR! Hopefully, this will play nicely with TableVectorizer :)
Here are a couple of quick remarks:
replace ` by `` Co-authored-by: Vincent M <maladiere.vincent@yahoo.fr>
Contributor
Author
|
Thanks for the comments @Vincent-Maladiere ! |
Vincent-Maladiere
approved these changes
Jun 23, 2023
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
Member
There was a problem hiding this comment.
Thanks @LeoGrin! LGTM after CI is green :)
jovan-stojanovic
requested changes
Jun 26, 2023
jovan-stojanovic
left a comment
jovan-stojanovic
left a comment
Member
There was a problem hiding this comment.
Thanks Leo! Two minor precision and this is good to be merged
|
|
||
| def test_deterministic(): | ||
| """Test that the encoder is deterministic""" | ||
| # TODO: add random state to encoder |
Member
There was a problem hiding this comment.
Is there randomness? If it's deterministic, no need for random state.
Contributor
Author
There was a problem hiding this comment.
Right now it's deterministic because the seed in the hash is fixed, but we could imagine allowing the user to vary the seed.
Co-authored-by: Jovan Stojanovic <62058944+jovan-stojanovic@users.noreply.github.com>
LilianBoulard
approved these changes
Jun 26, 2023
jovan-stojanovic
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We generate feature names as
feature_name_1_0, ...feature_name_1_n_componentsetc. If feature names are missing, we usex_0,x_1etc(+ a test to check that the MinHashEncoder is deterministic)