Skip to content

Prevent TableVectorizer from failing if there are missing values in a categorical column #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2023
Merged

Prevent TableVectorizer from failing if there are missing values in a categorical column #644

merged 3 commits into from
Jul 18, 2023

Conversation

LeoGrin
Copy link
Contributor

@LeoGrin LeoGrin commented Jul 18, 2023

Fix #643

GaelVaroquaux
GaelVaroquaux approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merging

@GaelVaroquaux GaelVaroquaux merged commit 8050248 into skrub-data:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TableVectorizer fails during transform when there are nans in a categorical variable
2 participants
@LeoGrin @GaelVaroquaux