-
Notifications
You must be signed in to change notification settings - Fork 129
Benchmark Early Stopping for the GapEncoder #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remarks:
|
I think taking the last should be okay, though we can check when I run the benchmarks on more datasets. (also it decreases the memory usage).
I think this would be useful! (I'll do it) |
Here is the updated result for commit 785082e ![]() |
Right now the version with early stopping is actually slower than the original version, I think because the |
See #681 |
This PR adds a script to benchmark the use of early stopping for GapEncoder.
The early stopping, implemented in a modified version of GapEncoder and enabled with
early_stop=True
, monitors the GapEncoder score everymonitor_steps
batches. As soon as the score increases (worsen) it triggers a counter with a limit given bypatience
batches. If afterpatience
batches the score has not been decreased, the process is ended.This PR is related to #593, where a previous benchmark is run to investigate GAPEncoder slowness.