Make GapEncoder a single-column transformer #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromedockes
commented
May 31, 2024
skrub/_dataframe/_common.py
Outdated
| "to_list", | ||
| "to_numpy", | ||
| "to_pandas", | ||
| "reset_index", |
Member
Author
There was a problem hiding this comment.
changes in this file are take from #919 and should be reviewed there
jeromedockes
commented
May 31, 2024
| from datetime import datetime | ||
|
|
||
| import numpy as np | ||
| import pandas as pd |
Member
Author
There was a problem hiding this comment.
changes in this file are take from #919 and should be reviewed there
jeromedockes
commented
May 31, 2024
| class GapEncoderColumn(BaseEstimator, TransformerMixin): | ||
| """GapEncoder for encoding a single column. | ||
| class GapEncoder(SingleColumnTransformer, TransformerMixin): | ||
| """Constructs latent topics with continuous encoding. |
Member
Author
There was a problem hiding this comment.
the docstring has been moved essentially unchanged from the previous GapEncoder with 2 minor changes:
- the docstring still mentioned 'empty_impute', but apparently the parameter has been renamed 'zero_impute'
- the docstring mentioned 'inverse_transform' but it doesn't seem to be defined
Member
There was a problem hiding this comment.
I assume that this was resolved after what we discuss in the meeting.
jeromedockes
changed the title
Member
|
@jeromedockes could you solve the conflicts |
glemaitre
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in skrub meetings.
Currently the actual functionality of the GapEncoder is implemented by the GapEncoderColumn. The GapEncoder is a wrapper that takes care of fitting a separate GapEncoderColumn to each column and collecting the results in a 2D array.
That part is now handled by the TableVectorizer, so we only need the GapEncoderColumn.
This PR essentially removes the GapEncoder, then renames GapEncoderColumn to GapEncoder