MAINT add support for Python 3.9 #939
Conversation
|
the macos + python 3.8 fails to install pre-commit; not really related to skrub. As #928 will redo the CI configuration I won't edit it here |
|
the latest scikit-learn release only supports 3.9 so I wonder if we should set that as our minimum supported version? OTOH we support older scikit-learn versions that work with python 3.8 |
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LTGM. Not really sure why we have those "required" GHA.
ah I see what happened -- we require all tests to pass in the CI before allowing to merge a PR. That includes the py3.10 tests, but they don't exist anymore because i replaced 3.10 with 3.9 (the matrix of os/python/dependencies combinations is already huge) I guess I'll just add 3.10 back; anyway this is temporary because your pixi PR will redo the configuration |
2 participants
closes #868, closes #815