Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODFE support and path forward with fork #2316

Open
KadekM opened this issue Feb 16, 2021 · 6 comments
Open

ODFE support and path forward with fork #2316

KadekM opened this issue Feb 16, 2021 · 6 comments
Labels

Comments

@KadekM
Copy link
Contributor

KadekM commented Feb 16, 2021

Due to licensing changes in ES, the OpenDistroForElastic will fork last viable ES (7.10) , and since 7.11 is already out they will probably start diverging soon.

I don't suppose you plan to maintain patches for 7.10 in meantime and in any fashion support both DBs?
If not I may just have to fork this and maintain it for ODFE. What do you think?

@sksamuel
Copy link
Collaborator

sksamuel commented Feb 16, 2021

I will probably support both (if both are popular) but I want to see what happens with ODFE first. Will it succeed or fizzle out. I remember when Hudson/Jenkins was forked and Hudson kind of died out. Mabye ODFE will take over and original ES will die out.

In other words, I'm delaying any decisions until I see what happens over the next month or three. I've also got to do this at the same time as adding dotty support.

But rest assured, I won't ignore ODFE if it takes off.

I'd be happy for anyone to join as a contributor here, regardless of how we proceed.

@KadekM
Copy link
Contributor Author

KadekM commented Feb 16, 2021

Sounds good. So the plan is to have a separate branch for 7.10 release so we can patch it as well in meantime? I'm happy to help out with any further changes

@sksamuel
Copy link
Collaborator

Yes we could do. I guess the only difference right now is the client dependency ?
We could even move the elastic dependency to another module and make it opt in - it's only a HTTP client after all.

@KadekM
Copy link
Contributor Author

KadekM commented Feb 16, 2021

I haven't tracked the changelog yet. But I guess in future there'll be more breaking changes so it's something we need to think of.

@sksamuel
Copy link
Collaborator

I've been reading about it here: https://discuss.opendistrocommunity.dev/c/forking-elasticsearch-kibana/50
So once they have something released we can branch 7.10 for that.

@sksamuel
Copy link
Collaborator

I don't see much action in the odfe fork at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants