Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException in JavaClient:42 getting content charset from entity #2545

Closed
longliveenduro opened this issue Oct 21, 2021 · 1 comment
Closed

NullPointerException in JavaClient:42 getting content charset from entity #2545

longliveenduro opened this issue Oct 21, 2021 · 1 comment

Comments

@longliveenduro
Copy link
Contributor

We have some cases where the content charset from the Apache HTTP entity is null:

JavaClient:42 : val contentCharset = Option(ContentType.get(entity)).fold(Charset.forName("UTF-8"))(_.getCharset)

This leads to a NPE in Scalas Codec:65:
val dec = charSet.newDecoder()
longliveenduro added a commit to longliveenduro/elastic4s that referenced this issue Oct 21, 2021
@longliveenduro
Fixing issue Philippus#2545, NullPointerException in JavaClient:42 ge…
fb77840 
…tting content charset from entity
@longliveenduro longliveenduro mentioned this issue Oct 21, 2021
Merged
sksamuel pushed a commit that referenced this issue Oct 22, 2021
@longliveenduro
Fixing issue #2545, NullPointerException in JavaClient:42 getting con…
c7f2532 
…tent charset from entity (#2546)
@sksamuel
Copy link
Collaborator

I've released 7.15.1 with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longliveenduro @sksamuel