Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] reduce legacy logic in test framework and refactor to scenarios #3342

Merged
merged 18 commits into from Sep 3, 2022

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 25, 2022

This PR reduces the amount of legacy logic by removing a number of old functions, and refactoring some content to the scenarios framework.

  • removes _make_args logic and replaces by direct calls to fixture generators in sporadic instances where it was still called. The logic is legacy and has been mostly replaced by scenarios.
  • replaces a leftover transformer test for numpy3D mtype input compatibility by a transformer scenario which uses numpy. The old test was in test_all_panel_transformers, the new scenario is TransformerFitTransformPanelUnivariateNumpyWithClassYOnlyFit
  • removes three of the four old transformer mixins from the test framework: _PanelToTabularTransformer, _SeriesToPrimitivesTransformer, _SeriesToSeriesTransformer. The _PanelToPanelTransformer is still in use in some transformers. The other mixins are no longer in use and replaced by transformer tags since a while already.
  • removes the shapelet transformers from _contrib. The shapelet transform has been migrated to the transformations module already, and the one diff - the contracted version - seemed buggy/incomplete.

@fkiraly fkiraly added module:tests test framework functionality - only framework, excl specific tests refactor Restructuring without changing its external behavior. Neither fixing a bug nor adding a feature. labels Aug 25, 2022
@fkiraly fkiraly requested a review from aiwalter as a code owner August 25, 2022 20:34
@fkiraly fkiraly merged commit 93af4b6 into main Sep 3, 2022
@fkiraly fkiraly deleted the transformer-tests-remove-old-mixins branch September 3, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:tests test framework functionality - only framework, excl specific tests refactor Restructuring without changing its external behavior. Neither fixing a bug nor adding a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant