Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expanding window splitter #627

Merged
merged 8 commits into from Jan 29, 2021

Conversation

koralturkk
Copy link
Contributor

@koralturkk koralturkk commented Jan 19, 2021

Reference Issues/PRs

Feature #552

What does this implement/fix? Explain your changes.

It adds a functionality crossvalidate models with an expanding window.

Does your contribution introduce a new dependency? If yes, which one?

No, it does not.

What should a reviewer concentrate their feedback on?

Still in debugging

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@mloning mloning added the implementing algorithms Implementing algorithms, estimators, objects native to sktime label Jan 19, 2021
@mloning mloning added this to Review in progress in Workstream: forecasting and series transformers via automation Jan 19, 2021
Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koralturkk - looks all good to me, very clean code!

Could we add a simple unit test to make sure it's behaving as expected?

@koralturkk
Copy link
Contributor Author

@mloning Yes, I was thinking of doing that, I still need to check the existing unit tests which are being used on other splitters. I will be updating the PR when the unit tests are also implemented.

@mloning
Copy link
Contributor

mloning commented Jan 20, 2021

Great - thanks @koralturkk!

@koralturkk
Copy link
Contributor Author

Hi @mloning, I have added a notebook example and unit tests, I would appreciate if you take a look and let me know if you want to add more.

@mloning mloning changed the title Feature expanding window Add expanding window splitter Jan 27, 2021
Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koralturkk - looks all good to me! Very clean code, great work!

I started playing around with the notebook and made some minor changes, mostly formatting and style.

Will leave this PR open a bit longer and merge later today or in the next few days!

@mloning
Copy link
Contributor

mloning commented Jan 29, 2021

Thanks again @koralturkk - now merging!

@mloning mloning merged commit 5b2951c into sktime:master Jan 29, 2021
Workstream: forecasting and series transformers automation moved this from Review in progress to Done Jan 29, 2021
uhbuhb pushed a commit to MLH-Fellowship/sktime that referenced this pull request Feb 8, 2021
* expanding window validation added

* credits edited

* test_window overlap fixed for training and test window

* codeowners edited

* Notebook examples added for expanding window

* unit tests for expanding window added

* Minor changes to notebook

Co-authored-by: Martin Walter <mf-walter@web.de>
Co-authored-by: mloning <markus.loning.17@ucl.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementing algorithms Implementing algorithms, estimators, objects native to sktime
Development

Successfully merging this pull request may close these issues.

None yet

3 participants