Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Editing document type hides tabs as if they're overflowing #15

Closed
stefankip opened this issue Apr 15, 2020 · 5 comments
Closed

Editing document type hides tabs as if they're overflowing #15

stefankip opened this issue Apr 15, 2020 · 5 comments
Labels
bug Something isn't working release/0.3.0

Comments

@stefankip
Copy link

Steps to reproduce:

  • Open a content item
  • Open the document type via the Info app
  • Save and close the document type
  • Open the Content app again
    Now the tabs are hidden as if they're overflowing.
@skttl skttl added the bug Something isn't working label Apr 21, 2020
@FransdeJong
Copy link
Contributor

If you resize the screen by only one pixel it resolves itself.
So maybe we could call the calculateWidth() function every time you open the Content tab this would be fixed right?

@skttl
Copy link
Owner

skttl commented Apr 24, 2020

It does the same whenever you open an infinite editor, ie. when editing DTGEs.

@FransdeJong
Copy link
Contributor

I don't experience the same behaviour with DTGE or another infinite editor.
Even if I go to edit the doctype and hit close instead of submit it doesn't behave like this.

It only callapses when I edit the doctype and hit submit

@skttl
Copy link
Owner

skttl commented Apr 26, 2020

a5d61d425380e12c8419616b3df2162fa4d8c66cchanges the logic from using window resize events to using a ResizeObserver. ResizeObserver is currently behind a flag in Safari (I guess Safari 14 which should be due anytime soon will have it), else its supported in all modern browsers.

@skttl skttl closed this as completed Apr 26, 2020
@stefankip
Copy link
Author

Correct link: a5d61d4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working release/0.3.0
Projects
None yet
Development

No branches or pull requests

3 participants