Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

People seem to ignore the long warning explaing why not to use 'ignor…

…eVersionIssues':

"EXTREMELLY UN-ADVISIBLE. When true, flexmojos will check if the compiler and the framework versions match.  Usually, you must use the same compiler and framework versions. Set this to true to avoid this check. EXTREMELLY UN-ADVISIBLE."

It is quite scarry to me, but doesn't seem enought, so this configuration got renamed to 'iKnowWhatImDoingPleaseBreakMyBuildIwontBlameFlexmojosForStopWorking'

I hope this now reduces the number of incidents related to try using compiler v1 with framework v2.
  • Loading branch information...
commit 8e21a5c1eb9eaab7a5d80228c6c66f54494c0b91 1 parent 72fbad2
Marvin Froeder velo authored
8 flexmojos-maven-plugin/src/main/java/org/sonatype/flexmojos/plugin/compiler/AbstractFlexCompilerMojo.java
View
@@ -691,9 +691,9 @@
* Usually, you must use the same compiler and framework versions. Set this to true to avoid this check. EXTREMELLY
* UN-ADVISIBLE.
*
- * @parameter default-value="false" expression="${flex.ignoreVersionIssues}"
+ * @parameter default-value="false" expression="${flex.iKnowWhatImDoingPleaseBreakMyBuildIwontBlameFlexmojosForStopWorking}"
*/
- private boolean ignoreVersionIssues;
+ private boolean iKnowWhatImDoingPleaseBreakMyBuildIwontBlameFlexmojosForStopWorking;
/**
* Only include inheritance dependencies of classes specified with include-classes.
@@ -3307,7 +3307,7 @@ private File resolveThemeFile( String artifactName, String themeName, String typ
public void versionCheck()
{
- if ( ignoreVersionIssues )
+ if ( iKnowWhatImDoingPleaseBreakMyBuildIwontBlameFlexmojosForStopWorking )
{
return;
}
@@ -3328,7 +3328,7 @@ public void versionCheck()
+ "' - Framework: '"
+ frameworkVersion
+ "'.\n"
- + " You can use 'ignoreVersionIssues' to disable this check. Please refer to Flexmojos maven doc.\n"
+ + " You can use 'iKnowWhatImDoingPleaseBreakMyBuildIwontBlameFlexmojosForStopWorking' to disable this check. Please refer to Flexmojos maven doc.\n"
+ "If you prefer fixing it instead of ignoring, take a look at: https://docs.sonatype.org/display/FLEXMOJOS/How+to+set+Flex+SDK+version";
throw new IllegalStateException( msg );
}
Please sign in to comment.
Something went wrong with that request. Please try again.