New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to inform users that default_root behaviour has changed. #120
Comments
Did you mean "project_folder" for the setting. I believe I set the settings to default to the old default. I'll verify when i get back to my computer though. Was there a particular command you were having issues with or was it all of them. I believe the setting for failing back is "default_root" for the value. |
Ah, and perhaps update the Readme.md and the default AdvancedNewFile.sublime_settings. Probably something along these lines? sublime_settings:
Readme.md
Lastly, I honestly hadn't been able to figure out what this setting does / means from the current description. ``
|
Hi Scott, The command i constantly use is 'new', and all of a sudden it stopped rooting at the project level, but instead defaulted to When discovered you had put out 1.5.1 and I looked through your commits, I came to the above realization. Then I set 'project_folder' as the 'new_file_default_root' setting and it works fine now. Cheers, |
Hmm unsure why it fell back to home. That should only happen if there it can't resolve. Anyways, I'll be sure to update the readme. Documentation isn't a strong suit for me, so thanks for the recommendation. Glad the plugin has been making things easier for you. Happy new year to you too. |
Ah, I see you did put something into the update readme, for some reason that didn't show up on mine, or else I closed it without noticing. If it defaults to Cheers, |
Hi Scott,
I just figured out that default_root: project_root no longer works, and that as of 1.5.1 you need to set up individual settings for default_root in for each of the new, move, copy commands:
new_file_default_root
rename_file_default_root
copy_file_default_root
be84395#diff-0994d3f547d1105beb6a24ace4f44472R412
Here in command_base.py, could I suggest that you check for existence of the above keys in settings, and if not, then use the original default_root settings? This would allow the current installations to continue to work as is but allow fine tuning of roots if needed.
My Python has pretty much gone by the wayside as I haven't touched it since my 2 week stint last year, but something like this (excuse the Ruby-like code). I can't remember if
self.settings.get
returns nil or blank string, but something along these lines.Keep up the great work! I use ANF every single day I code!
Brian
The text was updated successfully, but these errors were encountered: