Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In installation "make check" give syntax error #135

Closed
Samuel006 opened this issue Jan 27, 2016 · 4 comments

Comments

@Samuel006
Copy link

commented Jan 27, 2016

My OS:
ASP Linux Server 5 (Red Hat Enterprise Linux 5.1).
gcc-3.4.6.-9, bash-3.0-19.6
I try to install re2c-0.16.tar.gz:

> ./configure - OK

> make - OK

> make check - test failed

> make tests - test failed:

make all-am
make[1]: Entering directory /root/new_packs/re2c-0.16' Reconfigure to rebuild docs: ./configure --enable-docs make[1]: Leaving directory/root/new_packs/re2c-0.16'
./run_tests.sh
./run_tests.sh: line 52: syntax error near unexpected token "$arg"' ./run_tests.sh: line 52: * ) tests+=("$arg") ;;'
make: *** [tests] Ошибка 2

I replaced string 52 in file ./run_tests.sh:
* ) tests+=("$arg") ;;' to line: * ) tests=${tests}${arg} ;;'
And now "make check" work excelent.
Please check my correction.

@skvadrik skvadrik added this to the 0.17 milestone Jan 27, 2016

@skvadrik skvadrik self-assigned this Jan 27, 2016

skvadrik added a commit that referenced this issue Jan 27, 2016

run_tests.sh: avoid '+=' in bash arrays (compatibility with old bash).
See #135 "In installation "make check" give syntax error".
@skvadrik

This comment has been minimized.

Copy link
Owner

commented Jan 27, 2016

Your fix you is a bit incorrect: it glues all arguments together in one giant string (which is further interpreted as a single filename). The error is exposed when one invokes script with multiple filenames (something that make check does not).

I suggest the following fix: d4c322c

@Samuel006

This comment has been minimized.

Copy link
Author

commented Jan 28, 2016

I see. Thanks. All works properly with your fix, but syntax error appear one more time.
Need to replace string 217. From:
wait_pids+=("$!")
To:
wait_pids[${#wait_pids[@]}]="$!"
Is it right?

skvadrik added a commit that referenced this issue Jan 28, 2016

run_tests.sh: avoid another '+=' in bash arrays (compatibility with o…
…ld bash).

See #135 "In installation "make check" give syntax error".
@skvadrik

This comment has been minimized.

Copy link
Owner

commented Jan 28, 2016

Yes, that's correct. I should have checked all occurrences. :). Fix: 0bf6f26

@Samuel006

This comment has been minimized.

Copy link
Author

commented Jan 28, 2016

Thank you. : )

@Samuel006 Samuel006 closed this Jan 28, 2016

skvadrik added a commit that referenced this issue Feb 7, 2016

run_tests.sh: avoid '+=' in bash arrays (compatibility with old bash).
See #135 "In installation "make check" give syntax error".

skvadrik added a commit that referenced this issue Feb 7, 2016

run_tests.sh: avoid another '+=' in bash arrays (compatibility with o…
…ld bash).

See #135 "In installation "make check" give syntax error".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.