Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests under Windows #141

Closed
Abs62 opened this issue Apr 28, 2016 · 3 comments
Closed

Tests under Windows #141

Abs62 opened this issue Apr 28, 2016 · 3 comments
Assignees
Milestone

Comments

@Abs62
Copy link

@Abs62 Abs62 commented Apr 28, 2016

Under Windows (in MSYS) "run_tests.sh" script show a handreds failed tests because "2>"$outc.stderr"" operator write warning strings to file with CRLF instead of LF only. If to add something like "sed -i 's/\r//g' "$outc.stderr"" no more tests failed.

@skvadrik skvadrik added this to the 0.17 milestone Apr 29, 2016
@skvadrik skvadrik self-assigned this Apr 29, 2016
@skvadrik skvadrik closed this in 68cfccd Apr 29, 2016
@skvadrik
Copy link
Owner

@skvadrik skvadrik commented Apr 29, 2016

Abs62, I applied the fix you proposed. Thanks!

Loading

@skvadrik
Copy link
Owner

@skvadrik skvadrik commented Apr 29, 2016

I reopen the issue until you confirm that it works on windows (github automatically closed it based on commit 68cfccd message).

Loading

@skvadrik skvadrik reopened this Apr 29, 2016
@Abs62
Copy link
Author

@Abs62 Abs62 commented Apr 29, 2016

Yes, it works, all tests passed. Thanks.

Loading

@Abs62 Abs62 closed this Apr 29, 2016
skvadrik added a commit that referenced this issue Jul 30, 2017
Thanks to Abs62, who noted that under Windows (in MSYS) tests fail
because '2>"$outc.stderr"' dumps CRLF to file instead of LF
and proposed a fix:
    sed -i 's/\r//g' "$outc.stderr"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants