Remove extra zsh plugins now that we have zsh.before #78

Closed
skwp opened this Issue Apr 5, 2012 · 9 comments

4 participants

@skwp
Owner

@kylewest your input on this? in our default ~/.zshrc some plugins have sneaked in that don't apear to be general purpose. specifically 'heroku' and 'redis-cli' seem to be things that not everyone uses. I can see leaving ruby/rails/rake/gem plugins in there but those two I would get rid of and ppl can put them into their ~/.yadr/custom/zsh.before

@kylewest kylewest was assigned Apr 5, 2012
@kylewest
Collaborator

I'll look into this some more tomorrow. I think we could be even more ruthless. For instance, the ruby plugin doesn't do much (two aliases). gem hasn't been updated in 2+ years and I'm not sure it does anything ZSH wouldn't figure out right out of the box.

I put some more research in and post my opinion on what should stay. We'll go from there.

Kyle

@skwp
Owner

cool, agreed. I don't know what half of those do :)

@kylewest
Collaborator
  • autojump - Don't know what this does. Unknown

    • replaced by fasd, Remove (@skwp)
  • bundler - Aliases and completion for bundler. Keep

  • gem - completion for gem. 2-years old and I'm not sure if this gets you anything you wouldn't get out of the box with ZSH. Remove

  • git - Aliases for git commands. Some may conflict with yadr aliases. I don't use, consider removing.

  • gnu-utils - Completions for gnu-utils. Unknown

    • I don't use it, ppl can put it in their custom if they want, Remove (@skwp)
  • heroku - Heroku completions. 8 months old, Heroku recently released their toolbelt so usage may be limited. Remove

  • history-substring-search - This may be built into zsh. I can remove the plugin, type hub then up-arrow and scroll thru all recent hub commands. - Consider removing.

    • this was suggested by another user, it seems to not be built in, although Ctrl-R in yadr does something similar (though not identical)
  • rails - 10 rails aliases. Remove

  • rake - Disables globbing for rake tasks. I've never used this plugin and never had issue with rake trying to glob file names. Remove

  • redis-cli - Completions for redis. Remove

  • ruby - Two aliases. Remove

  • rvm - RVM completions and "stuff". Remove or only include if RVM installed Note: the latter may prevent users from removing it using custom before/after.

    • I've already merged your change to make it harmless to load, I would keep it in if it's harmless, since rvm has 3x as many forks as rbenv, it appears to be more popular currently (@skwp)
  • ssh-agent - Don't know what this does. Unknown

    • This automatically adds your ssh keys so that if you ssh to a remote server and want to say use git there, it will use your local machine's keys automatically forwarded by the agent. Very useful. (@skwp)
  • vi-mode - Sets bindkey and some PROMPT stuff. I like the way I do it better (#84). Consider Removing

  • zsh-syntax-highlighting - this doesn't exist in oh-my-zsh and I can't find it in the project. Remove

Consider Adding

  • github - completions for hub.

  • osx - open pwd in finder or finder directory in terminal, trash command to move to trash.

  • rbenv - I'd rather not, but see comments about RVM above.

@markcornick

fasd is a replacement for autojump, so the autojump plugin is not needed.

@gareth

Is the ssh-agent oh-my-zsh plugin really that useful?

I thought "standard practice" was to ssh-add -K [private key] which adds any identity files to your OS X keychain, no additional processes needed

@gareth

My mistake, I didn't notice that it also adds agent forwarding by default.

While useful, you should only agent forward to machines you completely trust, as it can result in a security risk. See documentation for the -A option under man ssh. Recommend not enabling this automatically for everyone.

@skwp
Owner

Yeah we'll probably remove it. @kylewest is working on cleaning up the plugin list down to the minimum. I'll just add this in for myself ..I only ssh to boxes I completely trust :)

@kylewest
Collaborator

@skwp, I did the research (above). All that's left is picking the final list and editing this line. You wanna knock that out so I don't have to branch / pull request for such a simple change?

Kyle

@skwp
Owner

Ok I'll take care of it, thanks Kyle

@skwp skwp was assigned Apr 13, 2012
@skwp skwp closed this in 20530e3 Apr 14, 2012
@zapatoche zapatoche pushed a commit that referenced this issue Apr 16, 2012
@skwp Remove extra zsh plugins. [Close #78]
Use .yadr/custom/zsh/before if you want your own list of plugins.
700187e
@ebothmann ebothmann pushed a commit that referenced this issue Aug 19, 2014
@skwp Remove extra zsh plugins. [Close #78]
Use .yadr/custom/zsh/before if you want your own list of plugins.
feef043
@chrisnankervis chrisnankervis pushed a commit to chrisnankervis/dotfiles that referenced this issue Oct 5, 2014
@skwp Remove extra zsh plugins. [Close #78]
Use .yadr/custom/zsh/before if you want your own list of plugins.
00046e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment