New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export chef keys #309
Export chef keys #309
Conversation
Please review and merge PR. @Joeper214 🙇 |
👍 I'll review it now. |
<% provide(:title, "Chef Server") %> | ||
<h1 class="page-header">Chef Server</h1> | ||
|
||
<dl class="dl-horizontal"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a point. I think so too.
I'll modify it. 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. 💃
entries.each do |e| | ||
zip_file_path = path == '' ? e : File.join(path, e) | ||
disk_file_path = File.join(@input_dir, zip_file_path) | ||
puts "Deflating #{disk_file_path}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use Rails Logger here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
Is this feature needs to be merged into |
Yes. It needs. |
LGTM! ありがとうございます。 🙇 |
No description provided.