Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix systray xfce #1267

Merged
merged 2 commits into from Jul 1, 2022
Merged

fix systray xfce #1267

merged 2 commits into from Jul 1, 2022

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #

Changes:

  • add a sed command to change dbus vendor conn.go file, both for Makefile (build locally) and .goreleaser-linux.yml

How to test this PR:

  • make build-systray and run on xfce desktop
  • also can download my built from here, extract it and test

Screencast:

xfce.mov

@0pcom
Copy link
Collaborator

0pcom commented Jun 25, 2022

this is using the binaries you compiled / the provided archive:

image

still a very inconsistent behavior.

However, I think there is a chance this is not to do with the systray, but instead with a delay caused by the rpc server.

[2022-06-25T14:30:04-05:00] WARN [systray:rpc_client]: RPC connection failed. Try again in 2 seconds.
[2022-06-25T14:30:08-05:00] INFO [systray:rpc_client]: RPC Connection established

if i click on the systray app very soon after starting the visor, it behaves strangely.
It takes time to initialize after clicking on it, and does not initialize the buttons / menu items when the visor has started.

I have the same issue with my rework of the systray.

I think we need a baseline measurement here, to eliminate the rpc connection delay as a possible cause of such failures.

@jdknives jdknives merged commit a17b70f into skycoin:develop Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants